Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to set a custom title to the PickFolder dialog #63

Closed
wants to merge 10 commits into from

Conversation

dropTableUsers42
Copy link

No description provided.

@btzy
Copy link
Owner

btzy commented May 28, 2022

Thanks for the PR. I have been thinking of doing something like this for a while, mainly because I haven't been able to find a good way to have the dialog name show in the system language on Linux, whether with GTK or portal.

The main issue with this feature is API and ABI breakage. This PR will break ABI in all interfaces and break API in the plain C interface (nfd.h), and NFDe doesn't really have a good transition path to perform ABI and API breaking changes. I would be interested to know what some of the more popular projects that depend on NFDe think about this.

@btzy
Copy link
Owner

btzy commented Jul 5, 2022

Related: mlabbe/nativefiledialog#104

@btzy
Copy link
Owner

btzy commented Apr 20, 2023

This won't be merged as is, due to ABI and API breakage. I intend to add support for custom titles for all dialogs in a new API, described in #92, and it would be totally new code different from what you have done. Are you still interested in contributing?

@btzy btzy closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants